Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tui: warn about large flows #4102

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Tui: warn about large flows #4102

merged 3 commits into from
Mar 3, 2021

Conversation

oliver-sanders
Copy link
Member

Address a minor point on the beta-0 roadmap.

Add a warning about using with large flows until we get it delta-driven.

See #3527

One off-topic change, got shellchecker to skip the .git dir.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • One off-topic change listed above
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added this to the cylc-8.0b0 milestone Feb 26, 2021
@oliver-sanders oliver-sanders requested a review from wxtim February 26, 2021 17:02
@oliver-sanders oliver-sanders self-assigned this Feb 26, 2021
@oliver-sanders @hjoliver
Update cylc/flow/scripts/tui.py
39788e9 
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
@oliver-sanders oliver-sanders removed the request for review from wxtim March 2, 2021 13:50
hjoliver
hjoliver approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can forgive the codecov patch fail in this case.

@hjoliver hjoliver merged commit 07c7f5c into cylc:master Mar 3, 2021
@oliver-sanders oliver-sanders deleted the tui-warning branch March 3, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-sanders @hjoliver